Unexpected behavior using orderBy

[HZ-labs]

Something wrong if the last element has another type

Using orderBy(data, ["value"], ["asc"])

const data = [
  { id: 1, value: "apple" },
  { id: 2, value: "banana" },
  { id: 3, value: "cherry" },
  { id: 4, value: 10 },
  { id: 5, value: 5 },
  { id: 7, value: 20 },
  { id: 6, value: "banana" },
];

// Result:
[
  { id: 1, value: "apple" },
  { id: 2, value: "banana" },
  { id: 3, value: "cherry" },
  { id: 5, value: 5 },
  { id: 4, value: 10 },
  { id: 7, value: 20 },
  { id: 6, value: "banana" },
]

But if we change a bit data, its OK:

const data = [
  { id: 1, value: "apple" },
  { id: 2, value: "banana" },
  { id: 3, value: "cherry" },
  { id: 4, value: 10 },
  { id: 5, value: 5 },
  { id: 6, value: "banana" },
  { id: 7, value: 20 },
];

// Result:
[
  { id: 1, value: "apple" },
  { id: 2, value: "banana" },
  { id: 6, value: "banana" },
  { id: 3, value: "cherry" },
  { id: 5, value: 5 },
  { id: 4, value: 10 },
  { id: 7, value: 20 },
]

Example https://codesandbox.io/p/sandbox/es-toolkit-orderby-22zkzm

[raon0211]

Thanks! We will check this.

[dayongkr]

Actually, lodash also have same this issue. But we have to fix this issue for expected behavior.

This problem can be fixed by handling type coercion.

I'll fix this issue today.

[raon0211]

This actually needs a little bit of more discussion, reopening the issue.

[raon0211]

I guess in this case, the ideal way of using orderBy would be:

orderBy(data, x => x.value.toString(), ["asc"])

This would ensure that all numbers and strings are converted into string before comparison.

[dayongkr]

I guess in this case, the ideal way of using orderBy would be:

orderBy(data, x => x.value.toString(), ["asc"])

This would ensure that all numbers and strings are converted into string before comparison.

We have additional ways that we convert into string just using map before using orderBy and use custom order function.

But I think custom key function is simpler than others.

[raon0211]

As you mentioned, I guess we might try with custom key generating functions. It would be much simple.