Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add options to disable Backup and Snapshot #281

Open
thdoan opened this issue Nov 27, 2022 · 5 comments
Open

[Feature Request] Add options to disable Backup and Snapshot #281

thdoan opened this issue Nov 27, 2022 · 5 comments

Comments

@thdoan
Copy link

thdoan commented Nov 27, 2022

Use case: my notes are already version controlled, so I don't use the Backup and Snapshot features.

Please add an option to disable Backup and Snapshot so that the empty Backup and Snapshot directories aren't created automatically on startup.

@davidbannon
Copy link
Member

thdoan, if you have snapshots and backups turned off then those directories are not used, they will remain empty and use negligible disk space. Its convenient for me ensure they are created at startup so, if they are being used, they can be used without first checking they exist. That saves a bit of (intrusive) time while those processes are happening.

Obviously, I will reconsider that if you can give me a reason why having those empty directories there is a problem.

Or do you mean you want tomboy-ng to "clean up" those directories when the feature is turned off. At first glance that might be sensible, if full of backup/snapshot files, they do take up some space. But some users turn that feature off and on again depending on where they are. A laptop might have access to a shared drive when at, maybe the office or home but not when out on the road, for example. So, again, I'd rather not.

I could easily add a button to "empty Backup | Snapshot" directories but, again, I would need a good reason to actually remove the directories (and ensure they stay removed) once they are empty.

So, please clarify.

Davo

@davidbannon
Copy link
Member

thdoan, I just realised that I did not truthfully answer your question. What I said above relates to Snapshots, not to Backup.

You cannot, at present, not use the backup facility. I am afraid that dates back to the earlier Tomboy, it did automatic backup but end users were unaware of it. Indeed, it was not useful unless the user was willing and able to go digging down in the backup directory with their file manager !

So, I did not add the Backup capability, I just made it useful. I would be reluctant to remove it altogether, it provides a measure of protection against network failure or machine crash that, while rare, does happen.

But we do end up with a lot of files in the Backup dir. And a lot of history that users may not want there. Unlike Snapshots, there is no automatic cap on what is retained and that is bad. Maybe a manual button to empty it or a time limit, "remove all backup notes more than one day old" type of approach ?

Thanks for raising this issue.

Davo

@thdoan
Copy link
Author

thdoan commented Nov 28, 2022

@davidbannon Thanks for the information. If the Snapshots directory remains empty then I'm fine with it. In regards to Backups, do you want me to rename this ticket to apply only to Backups so that you can track it in case someday you decide to add an option to disable it? If not, we can close this ticket :-).

@davidbannon
Copy link
Member

Lets leave it here for now. I will need to have a pretty close look at what effects not doing backups will have. The Backup unit is called from a lot of places ....

But I do think its something that needs attention.

Davo

@davidbannon
Copy link
Member

OK, lets think about this -

  1. Add a checkbox to Recover Tab, Settings, "enable backups"
  2. Add a button, same place, clear out all backups.

Things that write to Backup -

  1. Roll Back, both on 'open a note' and 'change its name'.
  2. Delete a note.
  3. Overwrite a note during sync.
  4. ??? Maybe thats all ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants