-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up stale binary after name change with windows msi updater #10355
Comments
NSIS has installer hooks but I think this one should be handled by us @amrbashir |
I feel it was a mistake to use package name instead of productName from tauri.conf.json "Sanctum Dev"
|
I agree it's nice to have an easy way of setting beta/dev names so they can be installed alongside release versions. |
Recent beta builds are no longer renaming the binary in a bundle to
productName
, keeping the rust crate name.The issue we're facing at KittyCAD/Zoo is that running the updater installs our new
zoo-modeling-app.exe
binary (new name) in theZoo Modeling App
directory, but doesn't remove the existingZoo Modeling App.exe
(old name), leaving it stale for the user to potentially get confused about.Is there a hook we could use to run some type of clean up script for that stale executable as we forge ahead with the tauri dependency bump that requires this binary executable name change? I'm assuming other tauri users would be in the same boat as the rust crate names are much more restrictive on what characters they allow (for instance, no space).
Thank you!
The text was updated successfully, but these errors were encountered: