Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up stale binary after name change with windows msi updater #10355

Closed
pierremtb opened this issue Jul 19, 2024 · 5 comments
Closed

Clean up stale binary after name change with windows msi updater #10355

pierremtb opened this issue Jul 19, 2024 · 5 comments
Labels
platform: Windows priority: 1 high scope: bundler The bundler used in our cli to make installers

Comments

@pierremtb
Copy link

pierremtb commented Jul 19, 2024

Recent beta builds are no longer renaming the binary in a bundle to productName, keeping the rust crate name.

The issue we're facing at KittyCAD/Zoo is that running the updater installs our new zoo-modeling-app.exe binary (new name) in the Zoo Modeling App directory, but doesn't remove the existing Zoo Modeling App.exe (old name), leaving it stale for the user to potentially get confused about.

image

Is there a hook we could use to run some type of clean up script for that stale executable as we forge ahead with the tauri dependency bump that requires this binary executable name change? I'm assuming other tauri users would be in the same boat as the rust crate names are much more restrictive on what characters they allow (for instance, no space).

Thank you!

@lucasfernog
Copy link
Member

NSIS has installer hooks but I think this one should be handled by us @amrbashir

@amrbashir amrbashir transferred this issue from tauri-apps/plugins-workspace Jul 22, 2024
@olexiyb
Copy link
Contributor

olexiyb commented Aug 2, 2024

I feel it was a mistake to use package name instead of productName from tauri.conf.json
With old approach if you need to install multiple versions to test them separately on Windows it used to be

"Sanctum Dev"
"Sanctum Beta"
"Sanctum"
The commit brakes

  • support of multiple version on windows
  • support of human named link on windows

image

@jjh42
Copy link

jjh42 commented Aug 8, 2024

I agree it's nice to have an easy way of setting beta/dev names so they can be installed alongside release versions.

@tweidinger tweidinger added priority: 1 high platform: Windows scope: bundler The bundler used in our cli to make installers labels Sep 5, 2024
@lucasfernog
Copy link
Member

lucasfernog commented Sep 16, 2024

Closed by #10962 and #10967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Windows priority: 1 high scope: bundler The bundler used in our cli to make installers
Projects
Status: Done
Development

No branches or pull requests

5 participants