-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Add lower_upper
constrain
#1438
Comments
I believe we still need signatures in the serializer/deserializer in the Stan repo, no? |
Ah good point, will do now |
@WardBrian having some troubles adding a single tuple overload for Would it be safe to add a separate |
Need to think about the implementation a bit. Might be worth starting in stanc3 and seeing which is more natural:
I think my preference would be number 1, but happy to discuss either. |
No worries! I don't really have a preference either way, so I'm happy with whichever option would be easiest on the implementation side |
With the merge of stan-dev/math#3087, the
lub_*
constrain and free functions now support a single tuple of bounds. It would be great to add thelower_upper
bounds type so that both bounds can be specified in a single function call.Example pseudo-stan:
This would be great for situations where parameter bounds depend on functions of other parameters, and there is some non-trivial computation shared by both bounds
The text was updated successfully, but these errors were encountered: