Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reminder to fix version numbers in Makevars files #595

Open
jgabry opened this issue Jul 24, 2023 · 2 comments
Open

Reminder to fix version numbers in Makevars files #595

jgabry opened this issue Jul 24, 2023 · 2 comments

Comments

@jgabry
Copy link
Member

jgabry commented Jul 24, 2023

CRAN is adding a warning if package version numbers are not strings (e.g. 2.26 vs '2.26'). This needs to be fixed in rstanarm's Makevars files.

@jgabry
Copy link
Member Author

jgabry commented Aug 31, 2023

@bgoodri I assume you got the email, but CRAN asked for this to be resolved by 2023-09-13, so about 2 weeks. We could just manually edit the Makevars files, but do you want to have rstantools just generate them instead?

RStan is more urgent so no worries about this in the next few days I guess, just wanted to put an update here.

@bgoodri
Copy link
Contributor

bgoodri commented Sep 7, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants