Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use posterior::autocovariance() once on CRAN #157

Open
jgabry opened this issue Sep 28, 2020 · 5 comments · Fixed by #215
Open

Use posterior::autocovariance() once on CRAN #157

jgabry opened this issue Sep 28, 2020 · 5 comments · Fixed by #215

Comments

@jgabry
Copy link
Member

jgabry commented Sep 28, 2020

Remember to replace the short term fix for issue #151 (in PR #155) by using posterior::autocovariance() once the posterior package is on CRAN. This will avoid having to maintain the same code in both packages.

@avehtari
Copy link
Collaborator

posterior is on CRAN. What needs to be done to add the dependency correctly?

@avehtari
Copy link
Collaborator

@jgabry reminding about this issue you had opened

@jgabry
Copy link
Member Author

jgabry commented Mar 24, 2023

Thanks. I will make a PR For this

@jgabry
Copy link
Member Author

jgabry commented Mar 24, 2023

Thanks. I will make a PR For this

#215

@jgabry jgabry reopened this Mar 30, 2023
@jgabry
Copy link
Member Author

jgabry commented Mar 30, 2023

Reopening this. For the CRAN submission I'm about to do I'm going to add using posterior::autocovariance if the posterior package is available but we won't require it. In the future we can decide if we want to require posterior (i.e., move it from Suggests to Imports), which should depend on how much we plan to use posterior inside loo. If we end up requiring posterior we can delete the autocovariance function from loo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants