Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setTransactionMessageFeePayerSigner should overwrite signer when different #2897

Open
steveluscher opened this issue Jun 30, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@steveluscher
Copy link
Collaborator

steveluscher commented Jun 30, 2024

Presently, setTransactionMessageFeePayerSigner() doesn't let someone change the TransactionSigner if one already exists. If I have a message where the fee payer is Bob(Address A)/Phantom and I want to change it to Bob(Address A)/Solflare, this won't:

if ('feePayerSigner' in transactionMessage)
return transactionMessage as ITransactionMessageWithFeePayerSigner<TFeePayerAddress> & TTransactionMessage;

As discussed in #2874.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants