Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation bar title shows below the iPhone x notch when transition to long form. #167

Open
4 of 9 tasks
sadeghgoo opened this issue Feb 7, 2022 · 0 comments
Open
4 of 9 tasks

Comments

@sadeghgoo
Copy link

Description

Hi;
I've just cloned the sample project and changed the short-form height of FullScreenNavController to .contentHeight(200). But after changing this property the navigation bar height changed and when the user drag the bottom sheet to transition to the long-form navigation bar title shows under the iPhone X notch.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

PanModal version: 1.2.7

iOS version: 14.5

Steps to reproduce:

Just use below config:

    var panScrollable: UIScrollView? {
        return nil
    }

    var topOffset: CGFloat {
        return 0.0
    }

    var springDamping: CGFloat {
        return 1.0
    }

    var transitionDuration: Double {
        return 0.4
    }

    var transitionAnimationOptions: UIView.AnimationOptions {
        return [.allowUserInteraction, .beginFromCurrentState]
    }

    var shouldRoundTopCorners: Bool {
        return true
    }

    var showDragIndicator: Bool {
        return false
    }
  
  var shortFormHeight: PanModalHeight {
    return .contentHeight(200)
  }

Expected result:

I expect the navigation title shows correctly.

Actual result:

title not shown correctly.

Attachments:

Simulator.Screen.Recording.-.iPhone.11.-.2022-02-07.at.15.06.29.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant