Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Is bookmarked" indicator realtime issue #85

Open
dominic248 opened this issue Oct 5, 2024 · 2 comments
Open

"Is bookmarked" indicator realtime issue #85

dominic248 opened this issue Oct 5, 2024 · 2 comments

Comments

@dominic248
Copy link

Issue description:

The link is already bookmarked, but the indicator only appears after I switch to another tab and then return to the bookmarked tab.
It's not showing the indicator in real-time when I open the link or refresh the page.

Please refer the sample video to reproduce the bug:

2024-10-05.mp4

Thank you so much for this wonderful self-hosted app!
Cheers!

@sissbruecker
Copy link
Owner

Can only reproduce this when refreshing the page, opening a link works fine. It's also only reproducable in Chrome.

It looks like both Chrome and Firefox reset the badge when refreshing the page. However Firefox then dispatches an event that indicates the the URL of the tab changed, while Chrome doesn't. To fix this the extension would need to be changed to not rely on detecting URL changes in tabs but instead to always update the badge on some tab update event. Ideally without triggering multiple requests to the linkding server, as there are a lot of events fired when just refreshing a tab.

@dominic248
Copy link
Author

Hey Sascha @sissbruecker ,

I found a solution for this issue
I enabled "Pre-load page information while browsing", so its working perfectly now
image

You may close this ticket if no more actions are needed as per you.

Thank you so much!
Have a great day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants