Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make it work with HTTP self-hosted but HTTPS-Only-Mode #40

Open
Zocker1999NET opened this issue May 12, 2023 · 4 comments
Open

Comments

@Zocker1999NET
Copy link

I sadly currently do not have the time to investigate, why this Add-on seems to require to disable HTTPS-Only-Mode so it is able to connect to HTTP services (even if those are whitelisted for HTTPS-Only-Mode), but that seems not to be required, as other add-ons manage to do that (example: https://github.com/regseb/castkodi, it can connect to a Kodi instance with HTTP only with HTTPS-Only-Mode enabled when the exception for that Kodi is set).

But being required to disable HTTPS-Only-Mode, without being able to use an controlled exception for that, is certainly unsafe for most cases. The HTTPS-Only-Mode forces you to register & think about, if you really want to visit certain pages, and fixes pages with valid TLS configuration but missing redirections / HSTS. And I, for my case, only use exceptions when connecting to servers using private IPs which go through a P2P VPN (which makes configuring HTTPS obsolete).

So I ask if someone might be able to look into this before I might gain time to look into it myself.

Refs #15 #25

PS: Otherwise, thanks for linkding & this extension, it saves me a lot of time for being a good solution to collect all the resources I still need to go through will working on my Bachelor thesis.

@zigzampow
Copy link

+1 here. I was struggling with the same issues and found that disabling HTTPS-Only worked fine. Even if I add the site as an exception, HTTPS-Only must be disabled

@justinwaltrip
Copy link

+1 here as well. Same issue and I would really like no avoid disabling HTTPS-Only globally for just this extension

@ismay
Copy link

ismay commented Jul 9, 2024

Yeah having to disable https only mode is not great.

@ismay
Copy link

ismay commented Jul 23, 2024

For those that are on linux on a tiling wm like me, this is how I've worked around this issue:

#!/bin/bash

# Ensure fzf runs search command in bash
export SHELL=/bin/bash

# https://stackoverflow.com/a/5947802
export NC=$'\e[0m'
export BLACK=$'\e[0;30m'

search-bookmark() {
  token=<your linkding token, ideally not hardcoded>
  linkding=<your linkding url>

  curl -s -G --data-urlencode "q=$1" "$linkding/api/bookmarks/" -H "Authorization: Token $token" |
    jq -r '.results[] | .url + "|" + (.tag_names | map("#" + .) | join(" "))' |
    awk -F '|' '{print $1,ENVIRON["BLACK"] $2 ENVIRON["NC"]}' OFS=' '
}

# Export function for subshells: https://docstore.mik.ua/orelly/unix3/upt/ch29_13.htm
typeset -fx search-bookmark

choice=$(
  echo -n '' |
  fzf --ansi --bind "change:reload:sleep 0.1; search-bookmark {q}" |
  awk -F ' ' '{print $1}'
)

if [ -z "$choice" ]; then
  exit 0
fi

xdg-open "$choice"

Not a proper replacement at all for the add-on, but I still thought I'd share it. I use it to quickly search linkding and select bookmarks to open, so it can at least replace the search functionality (for some).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants