Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge: Omnibox / address bar not show some bookmarks #31

Open
DHS1001 opened this issue Jan 16, 2023 · 2 comments
Open

Edge: Omnibox / address bar not show some bookmarks #31

DHS1001 opened this issue Jan 16, 2023 · 2 comments

Comments

@DHS1001
Copy link

DHS1001 commented Jan 16, 2023

hi there,

When trying to search using Omnibox / address bar in Edge, some saved bookmarks are not displaying.
Some examples are as follows:

https://www.isms.online/iso-27001/annex-a-11-physical-and-environmental-security/
https://info-savvy.com/iso-27001-annex-a-11-physical-and-environmental-security/

Using "ISO" and "annex" bring no results in Edge.
Just wondering how the search works and is there anything I need to set to make this searchable?

linkding: 1.16.0 (latest)
extention: 1.4

Thanks

@sissbruecker
Copy link
Owner

Can confirm it doesn't work in Chrome either (which Edge is based on). Debugging the extension it seems that Chrome converts the suggestions provided by the extension into XML, and then chokes on some characters like &, which it tries to convert into a HTML character entity reference:

Bildschirmfoto 2023-01-16 um 15 39 39

Since the XML is generated by Chrome itself, that looks like a bug in Chrome 😕. The extension provides suggestions through a JS callback, where no XML is involved:

const bookmarkSuggestions = results.map((bookmark) => ({
content: bookmark.url,
description: bookmark.title || bookmark.website_title || bookmark.url,
}));
suggest(bookmarkSuggestions);

For reference, the same works fine in Firefox:

Bildschirmfoto 2023-01-16 um 15 27 20

@DHS1001
Copy link
Author

DHS1001 commented Jan 22, 2023

@sissbruecker Thanks for the detail analysis, it is a bit painful where edge/chrome has this kind of issue/bug.
I am trying to find the pattern, some links are working:
https://learn.microsoft.com/en-us/power-platform/power-fx/data-types
can be searched by "microsoft" and "data" for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants