Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Dark mode theme selector doesn't animate #4883

Open
2 tasks done
mutewinter opened this issue Sep 17, 2024 · 1 comment · May be fixed by #4903
Open
2 tasks done

[bug]: Dark mode theme selector doesn't animate #4883

mutewinter opened this issue Sep 17, 2024 · 1 comment · May be fixed by #4903
Labels
bug Something isn't working

Comments

@mutewinter
Copy link

Describe the bug

Due to disableTransitionOnChange from https://github.com/shadcn-ui/ui/blob/main/apps/www/app/layout.tsx#L93, no dark: animations will function.

This means that the classes in ModeToggle aren't actually doing anything: https://github.com/shadcn-ui/ui/blob/main/apps/www/components/mode-toggle.tsx#L22-L23.

Affected component/components

ModeToggle

How to reproduce

Go to https://ui.shadcn.com/docs/dark-mode/next and change the theme. The icon will not animate.

Codesandbox/StackBlitz link

No response

Logs

No response

System Info

N/A

Before submitting

  • I've made research efforts and searched the documentation
  • I've searched for existing issues
@mutewinter mutewinter added the bug Something isn't working label Sep 17, 2024
@Lexachoc
Copy link

Lexachoc commented Sep 19, 2024

I also noticed about this and I fixed it.
Will make a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants