Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with DEPRECATED warnings for Rails 4 #939

Closed
abitrolly opened this issue Apr 7, 2020 · 3 comments · May be fixed by #940
Closed

Problem with DEPRECATED warnings for Rails 4 #939

abitrolly opened this issue Apr 7, 2020 · 3 comments · May be fixed by #940

Comments

@abitrolly
Copy link

Describe the bug

The warning below is issued every time a Rail 4 project is built.

DEPRECATION WARNING: Sprockets method `register_engine` is deprecated.
       Please register a mime type using `register_mime_type` then
       use `register_compressor` or `register_transformer`.

The error for Rails 5 is fixed by 553e785 which is in master, but not released.

Is would be very nice if a backport of 3.x version of twitter-bootstrap-rails could be released with this bugfix. Because 4.x is not compatible with Rails 4.

twitter-bootstrap-rails/twitter-bootstrap-rails.gemspec

Line 22 in a9a5b41

s.add_dependency 'actionpack', '>= 5.0', '< 7.0'

@abitrolly
Copy link
Author

Fixed by upgrading less-rails from ~> 2.7.0 to ~> 4.0.0.

@seyhunak
Copy link
Owner

Can you make a PR @abitrolly if it is possible?

@abitrolly abitrolly mentioned this issue Aug 26, 2020
Open
abitrolly added a commit to abitrolly/twitter-bootstrap-rails that referenced this issue Aug 26, 2020
@abitrolly
Require 'less-rails` 4.0.0+
6fd81f5 
Fixes seyhunak#939
@abitrolly
Copy link
Author

@seyhunak done above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require 'less-rails` 4.0.0+ abitrolly/twitter-bootstrap-rails
2 participants
@seyhunak @abitrolly