Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] urdf_LIBRARIES is still wrong #166

Open
JackBoosY opened this issue Jan 6, 2022 · 2 comments
Open

[cmake] urdf_LIBRARIES is still wrong #166

JackBoosY opened this issue Jan 6, 2022 · 2 comments

Comments

@JackBoosY
Copy link

When the user uses multiple configurations (dbg/rel/rel_with_dbg), urdf_LIBRARIES should be a cmake expression containing these configuration information, but at this time, using one find_library can only search for a configured library.

Suggetsions:

set(urdf_LIBRARIES urdfdom::urdfdom_model urdfdom::urdfdom_world urdfdom::urdfdom_sensor urdfdom::urdfdom_model_state)
@traversaro
Copy link
Contributor

There is already a variable called urdfdom_TARGETS (see https://github.com/conda-forge/urdfdom-feedstock/blob/4f5f046cb6f8c02d90e901356d17dc1052eb7e8c/recipe/test/CMakeLists.txt#L9 for an example of its use), I guess that one can be used by downstream libraries to link all the targets exported by urdfdom.

@JackBoosY
Copy link
Author

@traversaro Yeah, that should work. But it's just a workaround, not a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants