Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine test suite scripts #109

Open
DimmestP opened this issue Oct 1, 2021 · 0 comments
Open

Refine test suite scripts #109

DimmestP opened this issue Oct 1, 2021 · 0 comments

Comments

@DimmestP
Copy link
Collaborator

DimmestP commented Oct 1, 2021

From Edwards comments on pull request #92

  1. Explain the test data

I am finding it hard to understand the data in the tests, even though I am meant to know this code very well.
Could we describe in a comment what each plate plan and data means? For example:

This is a sample dataset with x samples and y reps, that we use for…

Bonus points for having some lines to visualise the data??? Maybe???

  1. Is there still scope to simplify?

Now we have good code coverage, is it possible to write even simpler unit tests for core capabilities of the function? E.G. with smallest-possible dataframes?

Or without a +RT column so that we don’t need a filter(Type == “+RT”) in a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant