Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace superseded "do" function calls #101

Open
DimmestP opened this issue Sep 30, 2021 · 5 comments
Open

Replace superseded "do" function calls #101

DimmestP opened this issue Sep 30, 2021 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@DimmestP
Copy link
Collaborator

DimmestP commented Sep 30, 2021

From #85 Flic's code review

In calculate_deltadeltacq_bytargetid(), dplyr::do() is SUPERCEDED, perhaps use alternatives suggested in dplyr docs (summarise(), nest_by() and across()) : https://dplyr.tidyverse.org/reference/do.html https://github.com/ewallace/tidyqpcr/blob/master/R/calculate_deltacq.R#L142

@ewallace
Copy link
Collaborator

Oh dear, I didn’t realise do() was superseded! That is a very nice function.

Low priority though, if it works?

@ewallace
Copy link
Collaborator

I have recently tried to look at this in other situations, and even though do() is superseded I still find it more intuitive in some situations.

@ewallace
Copy link
Collaborator

Update: dplyr::summarise now allows return of data frames. That means that we would be able to replace do calls with summarise calls, and update dplyr dependency to v1.0.0 or later.

@ewallace ewallace added the help wanted Extra attention is needed label Sep 26, 2022
@MichalLauer
Copy link

Hello!
Is this issue still relevant?:)

@ewallace
Copy link
Collaborator

Hello @MichalLauer - yes this issue is still relevant. I'm just reviewing and updating tidyqpcr. Currently do() still works, and is not generating warnings, but, it's still superseded.

I'm flagging as "help wanted".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants