Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number of stds complied with is wrong #24

Closed
mpadge opened this issue Nov 26, 2021 · 2 comments
Closed

Number of stds complied with is wrong #24

mpadge opened this issue Nov 26, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@mpadge
Copy link
Member

mpadge commented Nov 26, 2021

In addition to #23, the bssm submission of @helske also reports that 92 standards have been complied with:

✔️ All applicable standards [v0.1.0.007] have been documented in this package (92 complied with; 32 N/A standards)

Butt the report itself gives 181. Fix!
@mpadge mpadge added the bug Something isn't working label Nov 26, 2021
@mpadge mpadge mentioned this issue Nov 26, 2021
Closed
mpadge added a commit that referenced this issue Nov 26, 2021
@mpadge
fix get_stds_in_code to traverse all dirs for #24
cb5ccdb
@mpadge mpadge closed this as completed in 0649cc2 Nov 26, 2021
@mpadge
Copy link
Member Author

mpadge commented Nov 26, 2021

Sorry again @helske, the number of the linked HTML report simply neglected to include a unique() call, so included all repeated standards. Fixed now, and I'll update the linked HTML report accordingly.

mpadge added a commit to ropensci-review-tools/roreviewapi that referenced this issue Nov 26, 2021
@mpadge
update bssm reports for ropensci-review-tools/srr#24
8386d53
@mpadge
Copy link
Member Author

mpadge commented Nov 26, 2021

Reports updated. Only remaining glitch is that they report a total of 124 standards, when it should be 123. That's because of #25, the implementation of which means this will remain a one-off. Thanks @helske as always for helping so much to improve our systems!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpadge