Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

laravel_session cookie added to web routes by default #395

Open
oxyc opened this issue Aug 24, 2024 · 4 comments
Open

laravel_session cookie added to web routes by default #395

oxyc opened this issue Aug 24, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@oxyc
Copy link
Contributor

oxyc commented Aug 24, 2024

Version

v5

What did you expect to happen?

No set-cookie headers added for anonymous visitors

What actually happens?

laravel_session cookie added to responses

Steps to reproduce

request any route with web middleware applied

System info

No response

Log output

No response

Please confirm this isn't a support request.

Yes

@oxyc oxyc added the bug Something isn't working label Aug 24, 2024
@oxyc
Copy link
Contributor Author

oxyc commented Aug 24, 2024

I know I can turn off the session middleware stuff but would be better if those were opt-in or all page caches will break by default

@Log1x
Copy link
Member

Log1x commented Aug 24, 2024

Are you mainly referring to when on WordPress routes? Otherwise, Laravel always creates a session cookie like that with the session middleware.

@oxyc
Copy link
Contributor Author

oxyc commented Aug 24, 2024

When on WordPress routes. Im fine just removing the middleware though if you do want to go with this as the default. But I guess others might find it unexpected too since you cant cache responses with set-cookie and Europeans need to declare the cookie in a policy.

@Log1x
Copy link
Member

Log1x commented Aug 24, 2024

yeah it should definitely be easier to configure and have some saner defaults for wordpress. will figure something out 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants