Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[💡 FEATURE REQUEST]: Replace zap logger with the official Go log/slog logger #1750

Open
rustatian opened this issue Oct 13, 2023 · 5 comments
Open

[💡 FEATURE REQUEST]: Replace zap logger with the official Go log/slog logger #1750

rustatian opened this issue Oct 13, 2023 · 5 comments
Assignees
@rustatian
Labels
A-logs Area: logs C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..

Comments

@rustatian
Copy link
Member

Plugin

Logger

I have an idea!

The Golang official log/slog package is out from the experimental packages. It is time to update our zap logger from Uber with the official one.
@rustatian rustatian added C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. A-logs Area: logs labels Oct 13, 2023
@rustatian rustatian added this to the v2024.1.0 milestone Oct 13, 2023
@rustatian rustatian self-assigned this Oct 13, 2023
@Kaspiman
Copy link

Kaspiman commented Apr 3, 2024

Can i help you with this epic? Looks like there many simple work for PHP dev @rustatian

@rustatian
Copy link
Member Author

I'm still not sure about this ticket. According to the benchmarks, slog is much much slower than zap: link.

@rustatian
Copy link
Member Author

@Kaspiman btw, if you want to contribute, I can suggest you this ticket: #1742. Here, you may use json-rpc like payloads with method mapping to the RR RPC methods.

@Kaspiman
Copy link

Kaspiman commented Apr 3, 2024 •
edited
Loading

@rustatian I'm interested in implementing this feature, because of #1708 (comment)

@rustatian
Copy link
Member Author

rustatian commented Apr 3, 2024 •
edited
Loading

To move to the official packages, it has to be at least not so behind the zap in terms of performance. I don't think, that the slog update happened this year.

@rustatian rustatian removed this from the v2024.1.0 milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustatian rustatian

Labels
A-logs Area: logs C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
Jira 😄
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rustatian @Kaspiman