Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RAFT communicator instead of a separate communicator in WholeMemory #4

Open
Tracked by #48
teju85 opened this issue Aug 16, 2022 · 2 comments
Open
Tracked by #48

Use RAFT communicator instead of a separate communicator in WholeMemory #4

teju85 opened this issue Aug 16, 2022 · 2 comments
Assignees
@dongxuy04
Labels
good first issue Good for newcomers tech-debt Cleanup tasks

Comments

@teju85
Copy link
Member

teju85 commented Aug 16, 2022

PR #3 introduces include/whole_memory.h which currently seems to have its own communicator. In the future, we should be using the raft communicator handle instead.
@teju85
Copy link
Member Author

teju85 commented Aug 16, 2022

Similarly, there's also include/whole_nccl_memory.h which can be replaced with similar logic from RAFT too.

@teju85 teju85 added good first issue Good for newcomers tech-debt Cleanup tasks labels Aug 16, 2022
@BradReesWork BradReesWork mentioned this issue Jul 10, 2023
Closed
@BradReesWork BradReesWork mentioned this issue Aug 3, 2023
Open
@BradReesWork
Copy link
Member

BradReesWork commented Mar 15, 2024 •
edited
Loading

still waiting on RAFT for host comms (using NCCL but with host copy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dongxuy04 dongxuy04

Labels
good first issue Good for newcomers tech-debt Cleanup tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teju85 @BradReesWork @dongxuy04