Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: add cuspatial.GeoSeries.within to benchmarks #1354

Open
raybellwaves opened this issue Mar 5, 2024 · 1 comment
Open

[FEA]: add cuspatial.GeoSeries.within to benchmarks #1354

raybellwaves opened this issue Mar 5, 2024 · 1 comment
Labels
External Issues filed by people outside the team feature request New feature or request Needs Triage Need team to review and classify

Comments

@raybellwaves
Copy link

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Low (would be nice)

Please provide a clear description of problem you would like to solve.

I got a nice speed up doing cgdf["geometry"].within(cgeom) compared to geopandas. I took a quick look at the benchmarks in https://github.com/rapidsai/cuspatial/blob/branch-24.04/python/cuspatial/benchmarks/api/bench_api.py but didn't find it immediately. It may behave similar to point_in_polygon but my cgeom is a MULTIPOLYGON

Describe any alternatives you have considered

No response

Additional context

It may be worth having a benchmark notebook in https://github.com/rapidsai/cuspatial/tree/branch-24.04/docs/source/user_guide similar to https://github.com/rapidsai/cudf/blob/branch-24.04/docs/cudf/source/user_guide/performance-comparisons/performance-comparisons.ipynb

@raybellwaves raybellwaves added the feature request New feature or request label Mar 5, 2024
@GPUtester GPUtester added Needs Triage Need team to review and classify External Issues filed by people outside the team labels Mar 5, 2024
@GPUtester
Copy link
Contributor

Hi @raybellwaves!

Thanks for submitting this issue - our team has been notified and we'll get back to you as soon as we can!
In the mean time, feel free to add any relevant information to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Issues filed by people outside the team feature request New feature or request Needs Triage Need team to review and classify
Projects
Status: Todo
Development

No branches or pull requests

2 participants