You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
cuSpatial currently builds cuProj as part of its cmake, although they are supposed to be independent libraries. Also, cuProj tests and benchmarks include some cuSpatial files unnecessarily.
We should make them independent parts of a monorepo as much as possible.
Minimum reproducible example
No response
Relevant log output
No response
Environment details
No response
Other/Misc.
No response
The text was updated successfully, but these errors were encountered:
@harrism I agree that there are varying degrees of scope that this could take. Let's limit the scope in this PR and restructure parts of dependencies.yaml but leave the rest of the refactor for another PR.
I think what I would propose for the second PR is:
Consider adding a separate libcuproj package (with changes to build.sh, ci/build_cpp.sh, ci/build_python.sh, a new conda recipe, etc.)
libcuproj is header-only, so the conda package contents would be just headers (and it would define the build dependencies for those headers), like for rmm. It's also fine for us to just not have a libcuproj package and instead build the C++ code in the cuproj Python build steps, but the problem is really that libcuproj tests/benchmarks are being lumped with libcuspatial's build process, as far as I can tell. The need to isolate tests/benchmarks are enough for me to vote in favor of a separate conda package. I would still advocate for the C++ file organization above, either way.
Version
24.02
On which installation method(s) does this occur?
Docker, Conda, Source, Rapids-Compose
Describe the issue
cuSpatial currently builds cuProj as part of its cmake, although they are supposed to be independent libraries. Also, cuProj tests and benchmarks include some cuSpatial files unnecessarily.
We should make them independent parts of a monorepo as much as possible.
Minimum reproducible example
No response
Relevant log output
No response
Environment details
No response
Other/Misc.
No response
The text was updated successfully, but these errors were encountered: