[TRACKER] Ensure that estimator classes do not perform parameter validation on construction #6105
Labels
improvement
Improvement / enhancement to an existing function
Tech Debt
Issues related to debt
Tracker
For epoch-level tracking of work that encapsulates many stories
As required by cuml's development guide, estimator classes must adhere to the API and implementation guidelines put forth by scikit-learn to maximize compatibility.
Those guidelines require that estimators are initialized without any parameter validation or mutation:
Some of cuml's estimators do not adhere to that standard. This issue tracks checking all of cuml's estimator classes and potentially fixing them.
The following estimators have been checked and are confirmed to not perform any parameter validation or mutation during construction:
DBSCAN from cuml.cluster.dbscan
DBSCANMG from cuml.cluster.dbscan_mg
HDBSCAN from cuml.cluster.hdbscan.hdbscan
KMeans from cuml.cluster.kmeans
KMeansMG from cuml.cluster.kmeans_mg
IncrementalPCA from cuml.decomposition.incremental_pca
PCA from cuml.decomposition.pca
PCAMG from cuml.decomposition.pca_mg
TruncatedSVD from cuml.decomposition.tsvd
TSVDMG from cuml.decomposition.tsvd_mg
ForestInference from cuml.experimental.fil.fil
ElasticNet from cuml.linear_model.elastic_net
Lasso from cuml.linear_model.lasso
LinearRegression from cuml.linear_model.linear_regression
LinearRegressionMG from cuml.linear_model.linear_regression_mg
LogisticRegression from cuml.linear_model.logistic_regression
LogisticRegressionMG from cuml.linear_model.logistic_regression_mg
Ridge from cuml.linear_model.ridge
RidgeMG from cuml.linear_model.ridge_mg
TSNE from cuml.manifold.t_sne
UMAP from cuml.manifold.umap
KNeighborsClassifier from cuml.neighbors.kneighbors_classifier
KNeighborsClassifierMG from cuml.neighbors.kneighbors_classifier_mg
KNeighborsRegressor from cuml.neighbors.kneighbors_regressor
KNeighborsRegressorMG from cuml.neighbors.kneighbors_regressor_mg
NearestNeighbors from cuml.neighbors.nearest_neighbors
NearestNeighborsMG from cuml.neighbors.nearest_neighbors_mg
The following estimators are identified to either validate and/or mutilate init parameters:
LinearRegression from cuml.linear_model.linear_regression
LogisticRegression from cuml.linear_model.logistic_regression
The text was updated successfully, but these errors were encountered: