Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/ruby_smb/fscc/file_information.rb Missing Several File Information Classes #224

Open
gwillcox-r7 opened this issue May 9, 2022 · 0 comments

Comments

@gwillcox-r7
Copy link
Contributor

Not sure if we intend to add more file information classes here but seeing as this is just a mapping of numbers to names it might be good to add this in. From what I can see we are at the very least missing the following, don't have time to do a complete review:

FileAllocationInformation -> 19
FileAlternateNameInformation -> 21
FileAttributeTagInformation -> 35
FileCompressionInformation -> 28
FileHardLinkInformation -> 46

Might be good to look at https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-fscc/4718fc40-e539-4014-8e33-b675af74e3e1 which seems to define this and then update https://github.com/rapid7/ruby_smb/blob/master/lib/ruby_smb/fscc/file_information.rb accordingly to use these values. Should also update the spec reference URL whilst we are at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant