You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not sure if we intend to add more file information classes here but seeing as this is just a mapping of numbers to names it might be good to add this in. From what I can see we are at the very least missing the following, don't have time to do a complete review:
Not sure if we intend to add more file information classes here but seeing as this is just a mapping of numbers to names it might be good to add this in. From what I can see we are at the very least missing the following, don't have time to do a complete review:
FileAllocationInformation -> 19
FileAlternateNameInformation -> 21
FileAttributeTagInformation -> 35
FileCompressionInformation -> 28
FileHardLinkInformation -> 46
Might be good to look at https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-fscc/4718fc40-e539-4014-8e33-b675af74e3e1 which seems to define this and then update https://github.com/rapid7/ruby_smb/blob/master/lib/ruby_smb/fscc/file_information.rb accordingly to use these values. Should also update the spec reference URL whilst we are at it.
The text was updated successfully, but these errors were encountered: