Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileIdBothDirectoryInformation ShortNameLength Field Incorrect Definition #220

Open
gwillcox-r7 opened this issue May 9, 2022 · 0 comments
Open

FileIdBothDirectoryInformation ShortNameLength Field Incorrect Definition #220

gwillcox-r7 opened this issue May 9, 2022 · 0 comments

Comments

@gwillcox-r7
Copy link
Contributor

gwillcox-r7 commented May 9, 2022 •
edited
Loading

The ShortNameLength field in FileIdBothDirectoryInformationdefinition at https://github.com/rapid7/ruby_smb/blob/master/lib/ruby_smb/fscc/file_information/file_id_both_directory_information.rb#L22 is incorrect. It is defined as a unsigned 8 bit integer in our code but https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-fscc/1e144bff-c056-45aa-bd29-c13d214ee2ba?redirectedfrom=MSDN now defines it as a signed 8 bit integer. We should update this accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gwillcox-r7