Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting #192

Open
cdelafuente-r7 opened this issue Feb 8, 2022 · 0 comments
Open

Improve error reporting #192

cdelafuente-r7 opened this issue Feb 8, 2022 · 0 comments

Comments

@cdelafuente-r7
Copy link
Contributor

RubySMB exception usually consists of a simple string that includes the error code, error name and a custom message. It requires the caller to perform string comparison in the raw message string to get the exact error code or name. See this PR's comment.
I believe this can be improved by using more elaborate exception classes containing helpers to extract specific information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant