-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Allow programmatically controlling the ThemePanel
component
#382
Comments
Why are you interested in that? What are you trying to achieve in your app? |
I want to add a custom button in the header/footer that toggles a Also, when |
I am more interested about this in terms of what this achieves for your users? Why do you need Theme Panel in production? It was never meant as a component that the end user would see; it's just a tool for us to demo the theme options better and for the developer to explore their app style. |
I'm building a catalogue of premade components/sections. |
In general, I don't see why |
Feel free to PR We won't want to add a way to reassign hotkeys because using Theme Panel in a real app is not a case that we see as legitimate/realistic; nor it makes sense to add a dependency for that. |
Okay, I'll take a look today |
@vladmoroz |
ThemePanel
component is great, but I think it can be improved by allowing the user to control more of its behavior:open
andonOpenChange
toThemePanel
to control it's statenull
to disable a hotkey.Here are a couple of great custom hotkey hooks for inspiration:
https://github.com/JohannesKlauss/react-hotkeys-hook
https://github.com/arthurtyukayev/use-keyboard-shortcut
https://github.com/greena13/react-hotkeys
The text was updated successfully, but these errors were encountered: