From baf98624513229d65ff033152f6c0c7b74e2fcba Mon Sep 17 00:00:00 2001 From: Alexey Ryabov Date: Wed, 16 Aug 2023 16:18:41 +0300 Subject: [PATCH] [Avatar] Fix flashing of broken image (#2340) * [Avatar] Fix flashing of broken image * Use isomorphic `useLayoutEffect` * [Avatar] Bump patch version --- .yarn/versions/64fcd132.yml | 5 +++++ packages/react/avatar/src/Avatar.tsx | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .yarn/versions/64fcd132.yml diff --git a/.yarn/versions/64fcd132.yml b/.yarn/versions/64fcd132.yml new file mode 100644 index 000000000..50d060d51 --- /dev/null +++ b/.yarn/versions/64fcd132.yml @@ -0,0 +1,5 @@ +releases: + "@radix-ui/react-avatar": patch + +declined: + - primitives diff --git a/packages/react/avatar/src/Avatar.tsx b/packages/react/avatar/src/Avatar.tsx index 9277fc0eb..00899a5fb 100644 --- a/packages/react/avatar/src/Avatar.tsx +++ b/packages/react/avatar/src/Avatar.tsx @@ -120,7 +120,7 @@ AvatarFallback.displayName = FALLBACK_NAME; function useImageLoadingStatus(src?: string) { const [loadingStatus, setLoadingStatus] = React.useState('idle'); - React.useEffect(() => { + useLayoutEffect(() => { if (!src) { setLoadingStatus('error'); return;