Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IconFactory.PathIcons.STAR doesn't exists anymore #24

Open
Rdornier opened this issue Dec 7, 2022 · 3 comments
Open

IconFactory.PathIcons.STAR doesn't exists anymore #24

Rdornier opened this issue Dec 7, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@Rdornier
Copy link

Rdornier commented Dec 7, 2022

Bug report

Describe the bug
IconFactory.PathIcons.STAR doesn't exists anymore and seems to not be replaced by any other icon (code here).
This icon was used to show rating stars from OMERO when the user right clicks on an image from the OMERO browser and click on more info (line that does not compile anymore is here). If the image contains a rating on OMERO, then it throws an error and the menu does not appear.

To Reproduce
Steps to reproduce the behavior:

  1. Install OMERO extension
  2. Browse an image on OMERO that contain a rating start (at least one)
  3. Right click on the image in the browser and select more info.
  4. Bug appears

Expected behavior
Having the menu appears with star icons.
Is there a way to replace this line by something else (other icons stored somewhere else) ?

Desktop (please complete the following information):

  • OS: Windows 11
  • QuPath Version: 0.4.0
@Rdornier Rdornier added the bug Something isn't working label Dec 7, 2022
@petebankhead
Copy link
Member

It should be possible to use pretty much any JavaFX Node - for example an icon from FontAwesome through ControlsFX.

(I still plan to revisit the OMERO extension, but haven't even quite manage to 'finish' releasing v0.4.0 yet - currently working on updating StarDist first.)

@Rdornier
Copy link
Author

Rdornier commented Dec 7, 2022

Thanks for your fast answer.
By looking at the link you gave, I manage to replace IconFactory.createNode(QuPathGUI.TOOLBAR_ICON_SIZE, QuPathGUI.TOOLBAR_ICON_SIZE, IconFactory.PathIcons.STAR) by GlyphFontRegistry.font("icomoon").create("\u2605").size(QuPathGUI.TOOLBAR_ICON_SIZE).color(javafx.scene.paint.Color.GRAY) and no more error is then thrown.

Thanks again for your help
Best,

Rémy.

@petebankhead petebankhead transferred this issue from qupath/qupath Dec 15, 2022
@petebankhead
Copy link
Member

I've transferred this issue, since the icon was intentionally removed from QuPath (I presume...) - but a replacement needs to be added here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants