Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing invocation of np.sin in custom_feature_map.ipynb #133

Open
emanouil opened this issue Jun 18, 2023 · 0 comments
Open

Missing invocation of np.sin in custom_feature_map.ipynb #133

emanouil opened this issue Jun 18, 2023 · 0 comments

Comments

@emanouil
Copy link

It seems to me the definition of custom_data_map_func in custom_feature_map.ipynb
does not correspond to the mathematical expression.

coeff = x[0] if len(x) == 1 else functools.reduce(lambda m, n: m * n, np.pi - x)

gives the default function, when it should be
coeff = x[0] if len(x) == 1 else functools.reduce(lambda m, n: m * n, np.sin(np.pi - x))

to be consistent with the text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant