Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we can deal with UTF-8 appdir names. #106

Open
elbenfreund opened this issue Apr 16, 2016 · 1 comment · May be fixed by #161
Open

Make sure we can deal with UTF-8 appdir names. #106

elbenfreund opened this issue Apr 16, 2016 · 1 comment · May be fixed by #161
Assignees
@elbenfreund
Labels
in progress research needed
Milestone
0.13.0

Comments

@elbenfreund
Copy link
Collaborator

Dirnames provided by appdirs may or may not be unicode instances. We need to investigate this further and figure out how to deal with unicode chars in py27 and 34.
@elbenfreund elbenfreund added this to the 0.12.0 milestone Apr 16, 2016
elbenfreund added a commit that referenced this issue Apr 25, 2016
@elbenfreund
Make sure our paths in fixtures contain utf8
71d55c0 
in order to have confidence in our ability to handle utf8 path location
we just add random utf8 string named sub-dirs to our path fixtures.

Closes: #106
@elbenfreund elbenfreund self-assigned this Apr 25, 2016
@elbenfreund elbenfreund linked a pull request Apr 25, 2016 that will close this issue
Open
elbenfreund added a commit that referenced this issue Apr 25, 2016
@elbenfreund
Make sure our paths in fixtures contain utf8
21135e6 
In order to have confidence in our ability to handle utf8 path location
we just add random utf8 string named sub-dirs to our path fixtures.

We now have to wait for ``hamsterlib`` to fix #130

Closes: #106
@elbenfreund
Copy link
Collaborator Author

Need to wait for a fix in hamsterlib.

@elbenfreund elbenfreund modified the milestones: 0.13.0, 0.12.0 Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elbenfreund elbenfreund

Labels
in progress research needed
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

[#106] Make sure our paths in fixtures contain utf8 projecthamster/hamster-cli
1 participant
@elbenfreund