Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interesting quirk (bug?) with CooltrainerFAI #308

Closed
invalio19 opened this issue Jan 3, 2021 · 4 comments
Closed

Interesting quirk (bug?) with CooltrainerFAI #308

invalio19 opened this issue Jan 3, 2021 · 4 comments
Labels
bug docs

Comments

@invalio19
Copy link

I noticed while playing Pokémon Red that CooltrainerF would repeatedly switch out her Pokémon when between 10–20% HP, and would do so without fail, rather than roughly 25% of the time.

Looking at the code, it looks like the lines which are supposed to give her actions a 25% of happening is implemented incorrectly, so her actions actually happen 100% of the time (assuming HP conditions are met):

cp 25 percent + 1

should be followed by

ret nc

Perhaps some comments around this line could highlight that the 25% chance is effectively ignored?

On a separate note, she switched repeatedly and without fail until she first used a Hyper Potion, and then would never switch that Pokémon again. Perhaps some comments could be put in data/trainers/ai_pointers.asm indicating that the value given only refers to the number of items the Trainer can use per Pokémon, and doesn't account for switching?
@Rangi42
Copy link
Member

Rangi42 commented Jan 7, 2021

This kind of overlaps with #258: Gen 1 had a lot of bugs that could use documenting. Some of them have related comments in the source code already, like for Missingno, but there's no equivalent yet of pokecrystal's bugs_and_glitches.md (which lists 72 bugs and their fixes, with a couple more having still-open todo issues).

@Rangi42 Rangi42 closed this as completed in 2ee8ce2 Nov 3, 2021
SatoMew added a commit to SatoMew/pokered that referenced this issue Mar 26, 2022
@SatoMew
Squashed commit of the following:
e922b6f 
commit fe8d3c5
Author: vulcandth <[email protected]>
Date:   Sat Mar 26 15:59:36 2022 -0500

    Build the Virtual Console patches with `make red_vc` and `make blue_vc`  (pret#351)

commit 07df4a5
Author: Rangi <[email protected]>
Date:   Thu Mar 17 20:36:13 2022 -0400

    Refactor pkmncompress.c to use common.h

    Fixes pret#349

commit 570d83b
Author: Rangi <[email protected]>
Date:   Tue Mar 15 17:35:30 2022 -0400

    Use noreturn for usage_exit

commit e175577
Author: Rangi <[email protected]>
Date:   Tue Mar 15 17:29:07 2022 -0400

    Use -flto for all tools

commit a75dd22
Author: Rangi <[email protected]>
Date:   Tue Mar 8 21:52:57 2022 -0500

    Slightly refactor some C tools

commit 7e78c11
Author: Rangi <[email protected]>
Date:   Fri Mar 4 18:21:12 2022 -0500

    Gen 1's Minimize graphic was not a complete 8x8 tile

commit 9523681
Author: stringflow <[email protected]>
Date:   Thu Dec 9 17:30:15 2021 +0100

    Fix incorrect comment about money received after battle (pret#346)

    * fix incorrect comment about money received after battle

    * fix incorrect comment in wram.asm

commit 09e92c5
Author: Rangi <[email protected]>
Date:   Tue Nov 23 21:00:07 2021 -0500

    Use ~X instead of $ff ^ X

commit 865d37e
Author: Rangi <[email protected]>
Date:   Tue Nov 23 20:56:57 2021 -0500

    Use compound assignment operators

commit 64e2b66
Author: Rangi <[email protected]>
Date:   Tue Nov 23 20:53:05 2021 -0500

    Require rgbds 0.5.2

commit 157b593
Author: Rangi <[email protected]>
Date:   Sat Nov 6 13:24:19 2021 -0400

    Use `dn` for wave instrument samples, like pokecrystal

commit f68af5c
Author: Yoann Fievez <[email protected]>
Date:   Sat Nov 6 00:45:09 2021 +0100

    Add some constants for options (pret#344)

    Co-authored-by: Rangi <[email protected]>

commit 8349bfd
Author: Yoann Fievez <[email protected]>
Date:   Fri Nov 5 20:40:15 2021 +0100

    Refactorize check button pressed (pret#340)

commit b44a10a
Author: Yoann Fievez <[email protected]>
Date:   Thu Nov 4 20:17:17 2021 +0100

    Update 'make compare' for no pret repo and add 'make' for fork (pret#339)

commit 2ee8ce2
Author: Rangi <[email protected]>
Date:   Wed Nov 3 17:07:08 2021 -0400

    Comment on the CooltrainerFAI bug

    Fixes pret#308

commit e4845d3
Merge: 58d08bf 0af787e
Author: Rangi <[email protected]>
Date:   Tue Nov 2 19:58:17 2021 -0400

    Merge branch 'master' of https://github.com/pret/pokered

commit 58d08bf
Author: Rangi <[email protected]>
Date:   Tue Nov 2 19:57:08 2021 -0400

    Identify some percentage constant values

commit 0af787e
Author: IIMarckus <[email protected]>
Date:   Fri Oct 8 04:30:39 2021 -0600

    Kill Freenode.

commit fc899e1
Author: Rangi <[email protected]>
Date:   Tue Oct 5 21:02:42 2021 -0400

    `warp_event` warp IDs start at 1, like in pokegold/pokecrystal

commit 5266001
Author: Rangi <[email protected]>
Date:   Tue Oct 5 20:46:46 2021 -0400

    Clean up some redundant or unusual event comments

commit d48a318
Author: Rangi <[email protected]>
Date:   Sun Sep 26 23:20:57 2021 -0400

    Align `object_event` coordinates

    Fixes pret#336

commit 30acb46
Author: Amber Brault <[email protected]>
Date:   Sun Sep 26 22:57:55 2021 -0400

    Fix typos (pret#334)

commit 2c4f358
Author: Yoann Fievez <[email protected]>
Date:   Mon Sep 27 04:56:09 2021 +0200

    Unify map event gen1 gen2 (pret#335)

    * Update sign to bg_event pret#289

    * Rename warp to warp_event

    * Replace object to object_event

    * Move warp macro parameter from warp x, y, id, map to warp_event x, y, map, id

commit f1285f8
Author: Rangi <[email protected]>
Date:   Wed Sep 8 20:59:22 2021 -0400

    `ASSERT LOW(wSpriteStateData1) == 0 && LOW(wSpriteStateData2) == 0`

commit 7ee8a65
Author: Rangi <[email protected]>
Date:   Sat Aug 28 17:02:20 2021 -0400

    wcf4b -> wStringBuffer

commit 2364261
Author: SatoMew <[email protected]>
Date:   Sun Aug 1 03:53:52 2021 +0100

    Remove old tile animation comments (pret#333)

    They stopped being accurate after pret#304 and aren't really necessary.
@rawr51919
Copy link
Contributor

rawr51919 commented Jul 4, 2022 •
edited
Loading

I'll be adding a wiki tutorial with this fix to the wiki articles in the morning
EDIT: Tutorial added

@Rangi42
Copy link
Member

Rangi42 commented Jul 4, 2022

I'll be adding a wiki tutorial with this fix to the wiki articles in the morning

This issue is closed, and the wiki is free for anyone to edit without needing discussion and review and high standards for editing. Just go ahead and do it whenever.

@dannye
Copy link
Member

dannye commented Jul 4, 2022

Not only is the "status update" comment not necessary as Rangi pointed out, but it isn't even an update on anything actual.
It's just a statement of something you hope to do in the future. This is unhelpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dannye @rawr51919 @Rangi42 @invalio19