-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: buffer all region jobs and consider store balance #56112
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: lance6716 <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56112 +/- ##
=================================================
- Coverage 72.8947% 56.3454% -16.5494%
=================================================
Files 1611 1782 +171
Lines 447371 635975 +188604
=================================================
+ Hits 326110 358343 +32233
- Misses 101188 253090 +151902
- Partials 20073 24542 +4469
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
What problem does this PR solve?
Issue Number: close #56113
Problem Summary:
What changed and how does it work?
add
storeBalancer
and refine the components workflow. Now the behaviour of workflow is described in code comment
Previously I don't want to write many
select {case <- ctx.Done: ..., case ...}
for every channel action, so in the old code I assume the output channel must not be blocked (which means its reader/receiver must not exit earlier than writer/sender). But after I come back to this function after some months, I found it's hard to remember the different exit behaviour of components. So I changed them to new behaviours like comment said.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.