-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zora 0xsplits example? #2
Comments
hi @rubinovitz are you creating an onchain or premint contract/token? |
Do you have any documentation on pre-mint? Was unaware it was an option and the one link on Google is broken. Also can't find it in your docs. |
hi @rubinovitz we don't currently have much documentation on Premint (we need to add it). but here's some documentation on it from the sdk standpoint: to get a better understanding of how it works, you could look at the code for the premint client here: |
@oveddan thanks I think we’re going to do premint |
got it - splits on premint are not supported yet (but it's planned). |
@oveddan ok in that case can we do onchain? |
Yes it can be done onchain – you can submit the split on chain before a premint or submit both the mint and the split onchain. You can just use the splits SDK/API and then submit that address to the contract payoutaddress. |
we should have this supported in our sdk soon |
hey we have an updated sdk and example for creating with splits, check it out here: |
@oveddan is your documentation for contract metadata correct? If so what is the difference between image and imageURI? |
@oveddan The collection metadata here https://docs.zora.co/docs/smart-contracts/creator-tools/Deploy1155Contract is what @rubinovitz is referring to. I am also confused about how these two pages of documentation work together because there is also this one https://ourzora.github.io/zora-protocol/protocol-sdk/creator/onchain |
hey weve been migrating our docs so there is a bit of confusion/duplication between the two. For now you can know that: Contract metadata has the following json schema: {
"name": "{contract name}",
"description": "{contract description}",
"image": "{contract image}"
} Token metadata has the following json schema: {
"name": "{token name}",
"description": "{token description}",
"image": "{token image ipfs url}",
"animation_url": "{token media ipfs url}",
"content": {
"mime": "{content mime type}",
"uri": "{content ipfs uri}"
},
"attributes": {
"trait_type": "{trait type}",
"value": "{trait value}"
}
} Contract and token metadata should be pinned to IPFS using a preferred pinning service, |
Thanks!
What is the data type of the contract image?
…On Thu, Jun 27, 2024 at 12:57 PM Dan Oved ***@***.***> wrote:
hey weve been migrating our docs so there is a bit of
confusion/duplication between the two.
For now you can know that:
Contract metadata has the following json schema:
{
"name": "{contract name}",
"description": "{contract description}",
"image": "{contract image}"
}
Token metadata has the following json schema:
{
"name": "{token name}",
"description": "{token description}",
"image": "{token image ipfs url}",
"animation_url": "{token media ipfs url}",
"content": {
"mime": "{content mime type}",
"uri": "{content ipfs uri}"
},
"attributes": {
"trait_type": "{trait type}",
"value": "{trait value}"
}
}
Contract and token metadata should be pinned to IPFS using a preferred
pinning service,
and the url when set on a contract or token should be in an ipfs url
format, like: ipfs://{cid}
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANZMF6XDGUEBZWA7XQ4653ZJQ775AVCNFSM6AAAAABIXSHVLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJVGIYTQMBYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Clearly, there needs to be a contract to create a token, but I am confused as to why all fields in the contract metadata would be optional. |
Hi I’m trying to create new Zora NFTs with variable revenue splits using an embedded privy wallet and 0xsplits.
do you have examples of your 0xsplits integration I can look at?
Thank you!
The text was updated successfully, but these errors were encountered: