Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare next release #1325

Open
julien-truffaut opened this issue Nov 17, 2022 · 18 comments
Open

Prepare next release #1325

julien-truffaut opened this issue Nov 17, 2022 · 18 comments

Comments

@julien-truffaut
Copy link
Member

Here is the list of changes since 3.1.0: v3.1.0...master

We bumped the major version of the scala compiler to 3.2.1. I am not sure what is the impact.
I think the next version will be 3.2.0.

@armanbilge
Copy link
Contributor

I think the next version will be 3.2.0.

Yes indeed, I already bumped the "base version" in the build.sbt to reflect that.

tlBaseVersion := "3.2",

https://typelevel.org/sbt-typelevel/faq.html#what-is-a-base-version-anyway

@armanbilge
Copy link
Contributor

I think before the next release, the PGP_SECRET needs to be updated. I believe it has expired based on the CI logs.

You can generate a new key here:
https://typelevel.org/sbt-typelevel/secrets.html#pgp-key

If you use the online key generator, make sure to delete the PGP_PASSPHRASE secret.

@julien-truffaut
Copy link
Member Author

Thanks, I will regenerate one.

@yuriy-yarosh
Copy link

@armanbilge scala-native release would be highly appreciated as well.

@armanbilge
Copy link
Contributor

@yuriy-yarosh indeed, fortunately there is a snapshot available while we are waiting :)
https://s01.oss.sonatype.org/content/repositories/snapshots/dev/optics/monocle-core_native0.4_3/3.2-dcad42c-SNAPSHOT/

@julien-truffaut
Copy link
Member Author

Sorry for the delay. I will try to do it next week.

@julien-truffaut
Copy link
Member Author

@armanbilge I updated PGP_SECRET and deleted PGP_PASSPHRASE. What is the next step? should I create and publish a tag?

@armanbilge
Copy link
Contributor

@julien-truffaut great! Yes, you can either create/push a tag locally, or you can just create the release from the GH UI.
https://github.com/optics-dev/Monocle/releases/new

@julien-truffaut
Copy link
Member Author

Thanks, I didn't know about this UI. I triggered the build, let's cross our fingers :)

@julien-truffaut
Copy link
Member Author

publication failed with this error:

2023-01-03 14:39:25.982Z error [SonatypeClient]     Failed: signature-staging, failureMessage:No public key: Key with id: (48fbfd133fedb341) was not able to be located on <a href="http://pgp.mit.edu:11371/">http://pgp.mit.edu:11371/</a>. Upload your public key and try the operation again.  - (SonatypeClient.scala:385)
2023-01-03 14:39:25.984Z error [Sonatype] [STAGE_FAILURE] Failed to close the repository.  - (Sonatype.scala:440)

@armanbilge
Copy link
Contributor

@julien-truffaut did you submit the public key to the key server as explained here?
https://typelevel.org/sbt-typelevel/secrets.html#pgp-key

@julien-truffaut
Copy link
Member Author

Yes but I must have made a mistake. I regenerated a key and restarted the build and now it works :) Thanks

@armanbilge
Copy link
Contributor

Artifacts are live:
https://repo1.maven.org/maven2/dev/optics/monocle-core_3/3.2.0/

@julien-truffaut
Copy link
Member Author

I will try to write the release notes over the next week or two.

@armanbilge
Copy link
Contributor

armanbilge commented Jan 3, 2023

There's also an "auto-generate release notes" button in the GH UI :)

@julien-truffaut
Copy link
Member Author

Yeah but it isn't great

@julien-truffaut
Copy link
Member Author

@armanbilge I updated the release notes. If you have a minute wold you mind reviewing it?

@armanbilge
Copy link
Contributor

@julien-truffaut LGTM 👍 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants