Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly match on the actual KeywordContext symbol #1080

Open
yilinwei opened this issue Feb 18, 2021 · 2 comments
Open

Properly match on the actual KeywordContext symbol #1080

yilinwei opened this issue Feb 18, 2021 · 2 comments

Comments

@yilinwei
Copy link
Collaborator

Currently we're matching on Ident and strings; we should definitely be matching on specific symbols instead.
@yilinwei yilinwei mentioned this issue Feb 18, 2021
Merged
@kenbot
Copy link
Collaborator

kenbot commented Feb 19, 2021

Do you mean matching quotes, like case '{blah.each} => or something?

@kenbot
Copy link
Collaborator

kenbot commented Feb 22, 2021

How do you feel about this now that we have the FocusKeywordGiven machinery in ParserBase, @yilinwei ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kenbot @yilinwei