We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The traditional STAB naming of type parameters is obscure and a barrier to learning.
Proposed new names: PLens[SourceIn, SourceOut, TargetOut, TargetIn] Lens[Source, Target]
PLens[SourceIn, SourceOut, TargetOut, TargetIn]
Lens[Source, Target]
to be applied consistently across all code.
Question: what should we do about short variable names or lambda arguments, where we normally would use s, t, a or b? si, so, to, ti? sIn, etc?
s
t
a
b
si
so
to
ti
sIn
The text was updated successfully, but these errors were encountered:
Great idea, we should document whatever we decide for argument naming convient in a contributor.md
My vote go for: source, target if there is no ambiguity. Otherwise, sourceIn, sourceOut, targetIn, targetOut.
source
target
sourceIn
sourceOut
targetIn
targetOut
I also prefer update for TargetIn => TargetOut or TargetIn => F[TargetOut] and predicate for Target => Boolean
update
TargetIn => TargetOut
TargetIn => F[TargetOut]
predicate
Target => Boolean
BTW, I think it should be PLens[SourceIn, SourceOut, TargetIn, TargetOut] (last two type parameters swapped)
PLens[SourceIn, SourceOut, TargetIn, TargetOut]
Sorry, something went wrong.
No branches or pull requests
The traditional STAB naming of type parameters is obscure and a barrier to learning.
Proposed new names:
PLens[SourceIn, SourceOut, TargetOut, TargetIn]
Lens[Source, Target]
to be applied consistently across all code.
Question: what should we do about short variable names or lambda arguments, where we normally would use
s
,t
,a
orb
?si
,so
,to
,ti
?sIn
, etc?The text was updated successfully, but these errors were encountered: