Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up frozen author attribute logic #58

Open
joemull opened this issue Apr 1, 2022 · 1 comment
Open

Clean up frozen author attribute logic #58

joemull opened this issue Apr 1, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@joemull
Copy link
Member

joemull commented Apr 1, 2022

Now that the Account and FrozenAuthor models correspond better (as via openlibhums/janeway#2820) we should clean up a bit of the logic that adds author data to exports.
@joemull joemull added the enhancement New feature or request label Apr 1, 2022
@ajrbyers
Copy link
Member

ajrbyers commented Aug 3, 2022

Stuff to do:

  • Add to snapshot author method
  • Check for frozen_author.account.salutation and replace with frozen_author.salutation property
  • Add salutation to FA field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajrbyers @joemull