Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any introduction about api encode_with_unstable? #137

Open
fseasy opened this issue May 26, 2023 · 2 comments
Open

Any introduction about api encode_with_unstable? #137

fseasy opened this issue May 26, 2023 · 2 comments

Comments

@fseasy
Copy link

fseasy commented May 26, 2023

fn encode_with_unstable(

Hello, I'm reading the lib.rs code and found the encode_with_unstable api, tt donesn't seem to be used in the documentation?
But it occupied so much in the lib.rs, and the comments in code don't explain Why and What.
So maybe some extra explanation?

@hauntsaninja
Copy link
Collaborator

This is a great question. I have some nice internal documentation explaining what problem this is solving, I'll see if I can make a version of it that doesn't include internal-only details.

@ashleyholman
Copy link

ashleyholman commented Apr 21, 2024

Any update on this? I'm working on a PR for this repo and need to make sure I don't break encode_with_unstable. I think I get the main point that if you're splitting text arbitrarily, not necessarily aligned with the regex spits, the tokens at the boundaries where the split occurs might end up different than if the whole string were tokenized as one. But it would help to get some more backstory on the motivation for this and the use-cases that it's serving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants