Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels for closed + unmerged PRs #63

Open
Oberon00 opened this issue Oct 28, 2019 · 3 comments
Open

Labels for closed + unmerged PRs #63

Oberon00 opened this issue Oct 28, 2019 · 3 comments
Labels
release:after-ga Not required before GA release, and not going to work on before GA

Comments

@Oberon00
Copy link
Member

The OTEP process defines the states rejected and deferred which lead to closing a PR without it being merged. It would be great if we had & assigned labels to closed PRs to see in which state they are.
Additionally, I guess that OTEP 0008 is in a WIP state (to be reopened after being worked on by proposer) so labeling that would be good too.
@jmacd
Copy link
Contributor

jmacd commented Oct 28, 2019

Not sure if you're proposing a change. What labels do you suggest?
I intend to re-open 0008 today.

@Oberon00
Copy link
Member Author

My proposed change is to assign GitHub Labels to closed PRs (so no labels in the OTEP text, just in the GitHub UI).

@Oberon00
Copy link
Member Author

Oberon00 commented Jul 7, 2020

I still think this would be nice. Otherwise we can also remove the related sections from the OTEP process, if we don't really need this.

@andrewhsu andrewhsu added the release:after-ga Not required before GA release, and not going to work on before GA label Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release:after-ga Not required before GA release, and not going to work on before GA
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewhsu @Oberon00 @jmacd