Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus exporter export instrumentation scope attributes #5846

Open
pellared opened this issue Sep 25, 2024 · 0 comments · May be fixed by #5932
Open

Prometheus exporter export instrumentation scope attributes #5846

pellared opened this issue Sep 25, 2024 · 0 comments · May be fixed by #5932
Assignees
@pellared
Labels
enhancement New feature or request pkg:exporter:prometheus Related to the Prometheus exporter package
Milestone
v1.32.0

Comments

@pellared
Copy link
Member

pellared commented Sep 25, 2024 •
edited
Loading

Make Prometheus exporter to export instrumentation scope attributes

Prometheus exporter is REQUIRED to set the instrumentation scope attributes on the otel_scope_info metric: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk_exporters/prometheus.md and https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/prometheus_and_openmetrics.md#instrumentation-scope-1:

Scope attributes MUST also be added as labels following the rules described in the Metric Attributes section below.

CC @dashpole
@pellared pellared added enhancement New feature or request pkg:exporter:prometheus Related to the Prometheus exporter package blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made labels Sep 25, 2024
@pellared pellared mentioned this issue Sep 25, 2024
Closed
@dashpole dashpole self-assigned this Sep 25, 2024
@pellared pellared added this to the v1.32.0 milestone Oct 29, 2024
@pellared pellared assigned pellared and unassigned dashpole Oct 29, 2024
@pellared pellared removed the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Oct 30, 2024
@pellared pellared linked a pull request Oct 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pellared pellared

Labels
enhancement New feature or request pkg:exporter:prometheus Related to the Prometheus exporter package
Projects
None yet
Milestone
v1.32.0
Development

Successfully merging a pull request may close this issue.

prometheus: Add instrumentation scope attributes to otel_scope_info pellared/opentelemetry-go
2 participants
@dashpole @pellared