New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint Github Actions step auto approves #444

Open

zcstarr opened this issue Aug 16, 2021 · 0 comments

Labels

bug

Member

zcstarr commented Aug 16, 2021

Summary:
Github ESLint Action auto approves the commit even if lint has warnings.

Acceptance criteria:
We should re introduce local linting, either on commit with precommit hook, and use the github actions as a final safety guard.

zcstarr added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment