Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stagger image builds instead of building all of them at once #267

Open
benmandrew opened this issue Jan 23, 2024 · 4 comments
Open

Stagger image builds instead of building all of them at once #267

benmandrew opened this issue Jan 23, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@benmandrew
Copy link
Contributor

Currently we build the images on a weekly schedule, rebuilding all of them at once, which creates a large spike of demand on the cluster. It may be preferable to spread the builds out over the week.

We may wish to preserve the building-all-at-once behaviour for startup of the service.

@benmandrew benmandrew added the enhancement New feature or request label Jan 23, 2024
@shonfeder
Copy link
Contributor

It may be preferable to spread the builds out over the week

Could you elaborate a bit on the advantages of spreading them out? I can imagine some, but it would help us prioritize this issue to spell out the expected benefits :)

@mtelvers
Copy link
Member

mtelvers commented May 2, 2024

We often see failures when pushing to Docker Hub which appear to be related to multiple simultaneous pushes. Perhaps there is a rate or bandwidth limit? The failures need to be resubmitted manually. See #211

@shonfeder
Copy link
Contributor

We often see failures when pushing to Docker Hub which appear to be related to multiple simultaneous pushes.

Ah ha! That is a compelling motive for sure. But also automating the retries (perhaps after a delay?) also seems like it should be helpful per se, and maybe that should be tackled first?

@shonfeder
Copy link
Contributor

Rather than introducing scheduling changes to stagger the builds, @mtelvers suggested today that we could just build each OS in sequence (and the version and architecture matrix under each OS will then fan out and take a good amount of our build capacity for most OSs).

This will reduce the pressure on the system and instead carry out the builds in a slower (likely steadier) stream.

I'm provisionally in favor of this approach, as it is a simpler way of achieving the desired aim here, and seems to have nice properties overall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants