magit merge conflict color seem to be different color compared to vscode

[wingyplus]

From VSCode, I see merge conflict diss color like this:

But on Emacs:

[arcticicestudio]

Hi @wingyplus 👋, thanks for your contribution 👍

The difference between some ports is often due to the fact that some features are not always part of the application core like in this example Magit which is a third-party package. In #27 the support for Magit was already requested, but there hasn't been a PR. I'm not a Emcas user myself and since my free time I can spend on open source is limited and there are hundreds of other tasks the request is still pending.
Feel free to submit a PR to implement the required style faces, every contribution is always welcome 😊

---

Related to or duplicate of #27

[wingyplus]

@arcticicestudio Thanks for your reply. I'll take a look what I can do with this. :)

[wingyplus]

I just update on my research. It seems we need to decorate smerge theme. In the image below, I custom smerge-refined-added to use nord7. It's works but the color look hard to read.

[wingyplus]

Add 3 lines for smerge to the same diff looks better.

    ;; > smerge
    `(smerge-refined-added ((,class (:foreground ,nord14))))
    `(smerge-refined-changed ((,class (:foreground ,nord13))))
    `(smerge-refined-removed ((,class (:foreground ,nord11))))

[wingyplus]

Compare to diff in magit-show-commit. The result from previous comment looks very weired. 🤔

[arcticicestudio]

In order to achieve the same style like in VS Code, the background color must be "semi-transparent" by making use of the alpha layer value, but I'm not sure if it is supported by Emacs. We need to add new color variables which use the RGBA color model.