Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗃️ Add a level of depth to the schema structure to include an optional comment #33

Open
shnizzedy opened this issue Feb 3, 2024 · 0 comments

Comments

@shnizzedy
Copy link
Member

shnizzedy commented Feb 3, 2024

"type": "object",
"properties": {
"1": {
"type": "boolean",

Do we need one more level of depth for the items, to include the boolean and an optional comment?

#30 (comment)

Exactly, it would look something like this:

"2": {
  "type": "object",
  "title": "Documentation is up to date with version of software",
  "properties": {
    "value": {
      "type": "boolean",
      "default": false
    }
    "comment": {
      "type": "string",
      "default": ""
    }
  }
},

To avoid repetition this could be $def-ined once and then used for every item.

#30 (comment)

am I understanding correctly that the schema now supports comments, but the UI does not? Would it be a lot to add that to the UI, or should we kick the can on this and do it in a follow-up PR? I'm happy to kick the can

#30 (comment)

This PR does not add user comment support for items in any way. It just reimplements the currently public version with jsonschema + jsonforms and minor additions.
Of course this is easy to add, but I assume opening separate PRs for this and Jon's other points would make them easier for you all to review.

#30 (comment)

[#18] is adding comment support to the UI, [#33] is adding comment support to the schema

#30 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant