Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add comment boxes to checklist items #22

Closed
wants to merge 1 commit into from
Closed

Conversation

shnizzedy
Copy link
Member

@shnizzedy shnizzedy commented Nov 3, 2022

Adds a commentbox to each checklist item. Resolves #18.

Before

before

After

after

@shnizzedy shnizzedy linked an issue Nov 3, 2022 that may be closed by this pull request
@ReinderVosDeWael
Copy link

Should the comments expand to the entire page rather than the length of the line it's associated with? Short bullet points now also get very narrow comment fields.

@ReinderVosDeWael
Copy link

Also I'm not sure this meets the definition of done as laid out by #18. #18 mentions that "and include those comments in the badge / output", but I see no functionality for this.

@shnizzedy
Copy link
Member Author

Also I'm not sure this meets the definition of done as laid out by #18. #18 mentions that "and include those comments in the badge / output", but I see no functionality for this.

I wasn't able to make it to the meeting yesterday, so maybe it was decided then, but iirc we hadn't decided how we want the data to be formatted as output. (I see

Dorota will take our existing "schema" and turn it into a proper JSON schema.

in yesterday's meeting log).

This interactive subdirectory was built as a proof-of-concept prototype (hence the unaltered "Getting Started with Create React App" README) but seems to be becoming a working prototype. As it is, all the checks are stored in React state
image, and I believe these comments are as well with this PR.

Of

  1. Ability to add comments for each field
  2. Ability to save a json/csv record of the completed form

https://cmi-cnl.slack.com/archives/C05FXAZ316Z/p1694104612877259

(I'm not sure why we don't have an open issue for #​2), I think this PR resolves #​1 and including the comments in the badge/output is more of a requirement for the data display interface once #​2 is resolved.

@shnizzedy
Copy link
Member Author

Should the comments expand to the entire page rather than the length of the line it's associated with? Short bullet points now also get very narrow comment fields.

Makes sense to me. I doubt I'll prioritize this anytime soon though, if anyone else once to update the styling

@gkiar
Copy link
Member

gkiar commented Sep 11, 2023

@djarecka : I was talking to @shnizzedy and @nx10 about updating the web form, which would require this. @nx10 is willing to build out the schema, but just wanted to make sure he wasn't stepping on toes: that all-good from your side?

@djarecka
Copy link
Member

I haven't started working on this, so feel free to work on this! Thanks @nx10!

@shnizzedy
Copy link
Member Author

Superseded by #30

@shnizzedy shnizzedy closed this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💄 Add UI for comments
4 participants