Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add Resolution field to metadata if data has res entity #754

Merged
merged 2 commits into from
Oct 27, 2022
Merged

ENH: Add Resolution field to metadata if data has res entity #754

merged 2 commits into from
Oct 27, 2022

Conversation

mgxd
Copy link
Contributor

@mgxd mgxd commented Oct 18, 2022

Closes #752

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022 •
edited
Loading

Codecov Report

Base: 62.22% // Head: 62.35% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (801e2c7) compared to base (5b898c4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
+ Coverage   62.22%   62.35%   +0.13%     
==========================================
  Files          49       49              
  Lines        5935     5956      +21     
  Branches     1167     1173       +6     
==========================================
+ Hits         3693     3714      +21     
  Misses       2060     2060              
  Partials      182      182
Flag Coverage Δ
reportlettests ∅ <ø> (∅)
unittests 49.40% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
niworkflows/interfaces/bids.py 96.39% <100.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mgxd mgxd requested a review from effigies October 19, 2022 13:47
@effigies
Copy link
Member

We should do the same with den, which CIFTI and GIFTI files may have.

@mgxd
Copy link
Contributor Author

mgxd commented Oct 21, 2022

@effigies Do you have any suggestions on how to grab that information? Load up the gii/dtseries.nii and sum the vertices / grayordinates?

@effigies
Copy link
Member

I assumed there was metadata, as with res.

@mgxd
Copy link
Contributor Author

mgxd commented Oct 21, 2022

Nope, opened templateflow/templateflow#145 though

@effigies effigies merged commit c57aad4 into nipreps:master Oct 27, 2022
@mgxd mgxd deleted the fix/res-metadata branch October 27, 2022 18:26
@mgxd mgxd mentioned this pull request Oct 27, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies Awaiting requested review from effigies

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing metadata for res and den outputs
3 participants
@mgxd @codecov-commenter @effigies