Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cutadapt trim_nextseq config typo #429

Closed
cmatKhan opened this issue Oct 21, 2024 · 1 comment
Closed

cutadapt trim_nextseq config typo #429

cmatKhan opened this issue Oct 21, 2024 · 1 comment

Comments

@cmatKhan
Copy link

The parameter documentation

"help_text": "This enables the option Cutadapt `--nextseq-trim=3'CUTOFF` option via Trim Galore, which will set a quality cutoff (that is normally given with -q instead), but qualities of G bases are ignored. This trimming is in common for the NextSeq- and NovaSeq-platforms, where basecalls without any signal are called as high-quality G bases.",

and the cutadapt docs

https://cutadapt.readthedocs.io/en/stable/guide.html#nextseq-trim

seem to say that the cutadapt parameter is nextseq-trim. But the conf file sets it to just nextseq

https://github.com/nf-core/chipseq/blob/76e2382b6d443db4dc2396e6831d1243256d80b0/conf/modules.config#L138C50-L138C57

I think that should read:

params.trim_nextseq > 0 ? "--nextseq-trim ${params.trim_nextseq}" : '',

rather than

params.trim_nextseq > 0 ? "--nextseq ${params.trim_nextseq}" : '',
@cmatKhan
Copy link
Author

edit -- nextseq is the correct trimgalore setting. my bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant