Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admin to override catalog-banner and login-banner #26

Open
bodom0015 opened this issue Aug 25, 2023 · 0 comments
Open

Allow admin to override catalog-banner and login-banner #26

bodom0015 opened this issue Aug 25, 2023 · 0 comments

Comments

@bodom0015
Copy link
Member

bodom0015 commented Aug 25, 2023

As the admin of a Workbench installation, It would be nice if there was a way to override the catalog-banner and/or login-banner at runtime. The user could provide a URL for the image in question (stretch goal: also base64 encoded data url?)

Those image URLs would be used to display one or both banners in the webui


Full transcript of the request can be found below

Kevin Coakley

1:34 PM
Can I make a suggestion for a new feature? I would like to make https://github.com/nds-org/workbench-webui/blob/develop/public/catalog-banner.jpg and https://github.com/nds-org/workbench-webui/blob/develop/public/login-banner.jpg a variable in the Helm under config.frontend.customization like the other links. I don't need to be able to embed the images in the docker container, I can host them on another webserver. I looked at seeing if I could do it, but I don't know typescript and I didn't see any easy way to make variables like that.

Sara Lambert

1:50 PM
That definitely sounds like a cool idea, if we can make it work! It should be easy enough to allow the user to override the existing images... But the custom CSS there might make that a bit more tricky :thinking_face:
I think those images have some special styling on them (to adjust the viewport and display them differently in "dark mode")
New

Kevin Coakley

2:27 PM
If i wanted to change the two images now, would I just clone the repo, replace the images with new images, build the new container, and update the helm config to use the new container?

Sara Lambert

2:31 PM
That sounds correct, yes 👍
the actual image files are located in the "public" folder
The LoginBanner component and styling can be found in src/views/landing/
And the catalog-banner for the AllApps view can be found in src/views/all-apps/SearchCatalogHeader.tsx (this one was poorly named, sorry!) (edited)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant