Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/adjust info link validation requirement #335

Open
bodom0015 opened this issue Jan 13, 2021 · 0 comments
Open

Remove/adjust info link validation requirement #335

bodom0015 opened this issue Jan 13, 2021 · 0 comments

Comments

@bodom0015
Copy link
Member

When creating/editing an application spec, the "Information" field requires that the URL entered be a subpage of the NDS Confluence Wiki: Please provide a valid subpage of the NDS Confluence wiki. The form cannot be saved otherwise.

Option A: Remove the Validation Requirement

This requirement should be removed, since we already have cases in CHEESEhub where this link does not point to the NDS wiki and therefore would break this validation if editing the spec is required.

Option B: Adjust the Criteria of the Validation

Another option might be to compromise and adjust it so that these info pages must be a part of github.io and/or the (currently empty) github wiki associated with ndslabs. That would fit the CHEESEhub use case while leaving other possible options intact for future deployments.

Option C: Make it Configurable

If this validation might still be helpful per-instance, then we could maybe make it configurable? It should be easy enough to allow the admin to specify a list of allowed prefixes for this validation when deploying Workbench. If keeping this feature around is more effort than it is worth, it can be removed unless requested specifically by stakeholders.

Note that this will affect:

  • Validation / message of that field
  • Tooltip for that field
  • The link above leading to external wiki
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant